Publish block before returning to proposer #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 17.86% 17.77% -0.10%
==========================================
Files 20 20
Lines 3660 3679 +19
==========================================
Hits 654 654
- Misses 2924 2944 +20
+ Partials 82 81 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ruteri
reviewed
Apr 3, 2023
samczsun
approved these changes
Apr 3, 2023
blombern
pushed a commit
to ultrasoundmoney/mev-boost-relay
that referenced
this pull request
Apr 3, 2023
* publish block first * Add concurrent release of the execution payload * Fix capture * Update logging * Log the whole URI * add 1s delay on returning getPaylaod * fix naming --------- Co-authored-by: Mateusz Morusiewicz <11313015+Ruteri@users.noreply.github.com>
|
"pri y" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The relay should publish the block to the beacon network before returning to the proposer (nd if that fails not return the payload to the proposer at all).
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md